Open
Conversation
Denrage
force-pushed
the
feat/codestyle_update
branch
from
3fd2aeb to
60c72a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update of the current editorconfig and applying the rules to the Blish-Hud-Core codebase to get it in a somewhat consistent manner. I excluded every change that could introduce Breaking-Changes (unused method parameters, fields, etc., namespace adjustments), which should be looked at at another time.
Which options should be suggestions/warnings/errors are of course always debatable. The most important part is, that it is consistent
Is this a breaking change?
Breaking changes require additional review prior to merging. If you answer yes, please explain what breaking changes have been made.
No, explicitly did not update the namespaces to prevent breaking changes. This should still be addressed at a later time.