Build Warnings - Suppress CS1591 and resolve CS0067, CS0168, CS0419, CS1571, CS1574, and CS1584#1015
Open
ConfoundedHermit wants to merge 4 commits intoblish-hud:devfrom
Open
Build Warnings - Suppress CS1591 and resolve CS0067, CS0168, CS0419, CS1571, CS1574, and CS1584#1015ConfoundedHermit wants to merge 4 commits intoblish-hud:devfrom
ConfoundedHermit wants to merge 4 commits intoblish-hud:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion Reference
All new features must be discussed prior to code review. This is to ensure that the implementation aligns with other design considerations. Please link to the Discord discussion:
https://discord.com/channels/531175899588984842/536970543736291346/123123123123123
Is this a breaking change?
Breaking changes require additional review prior to merging. If you answer yes, please explain what breaking changes have been made.
No.
Pull Request Description
Fix compiler warnings: Suppress CS1591 and resolves CS0067, CS0168, CS0419, CS1571, CS1574, and CS1584
This PR addresses multiple compiler warnings to reduce build noise so attention is focused on impactful feedback:
Changes made:
<NoWarn>CS1591</NoWarn>to project file to suppress missing XML documentation warnings during buildMenuItemSelectedevent declaration inRegisteredSettingsMenuItem.csSharpDXExceptionvariable with debug logging inGraphicsService.csActiveControlChangedtoFocusedControlChangedinControl.cs<paramref>instead of<param>tagsAsyncTexture2D.csandIDataReader.cs<see cref="">tags with proper<see href="">for external URLscrefattributes in documentation commentsFiles changed: 18 files across Controls, GameServices, and Utils namespaces, with 46 additions and 42 deletions total.