Skip to content

Build Warnings - Suppress CS1591 and resolve CS0067, CS0168, CS0419, CS1571, CS1574, and CS1584#1015

Open
ConfoundedHermit wants to merge 4 commits intoblish-hud:devfrom
ConfoundedHermit:dev
Open

Build Warnings - Suppress CS1591 and resolve CS0067, CS0168, CS0419, CS1571, CS1574, and CS1584#1015
ConfoundedHermit wants to merge 4 commits intoblish-hud:devfrom
ConfoundedHermit:dev

Conversation

@ConfoundedHermit
Copy link
Copy Markdown

Discussion Reference

All new features must be discussed prior to code review. This is to ensure that the implementation aligns with other design considerations. Please link to the Discord discussion:

https://discord.com/channels/531175899588984842/536970543736291346/123123123123123

Is this a breaking change?

Breaking changes require additional review prior to merging. If you answer yes, please explain what breaking changes have been made.

No.

Pull Request Description

Fix compiler warnings: Suppress CS1591 and resolves CS0067, CS0168, CS0419, CS1571, CS1574, and CS1584

This PR addresses multiple compiler warnings to reduce build noise so attention is focused on impactful feedback:

Changes made:

  • CS1591 (XML documentation warnings): Added <NoWarn>CS1591</NoWarn> to project file to suppress missing XML documentation warnings during build
  • CS0067 (unused event warnings): Removed unused MenuItemSelected event declaration in RegisteredSettingsMenuItem.cs
  • CS0168 (unused variable warnings): Added proper usage of SharpDXException variable with debug logging in GraphicsService.cs
  • CS0419 (ambiguous reference warnings): Fixed incorrect event handler reference from ActiveControlChanged to FocusedControlChanged in Control.cs
  • CS1571 (invalid param reference):
    • Fixed XML documentation parameter references using <paramref> instead of <param> tags
    • Added missing parameter documentation for methods in AsyncTexture2D.cs and IDataReader.cs
    • Corrected parameter references in multiple utility classes
  • CS1574/CS1584 (invalid cref warnings):
    • Replaced invalid <see cref=""> tags with proper <see href=""> for external URLs
    • Fixed broken XML documentation cross-references throughout ArcDPS models
    • Corrected malformed cref attributes in documentation comments

Files changed: 18 files across Controls, GameServices, and Utils namespaces, with 46 additions and 42 deletions total.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant