Add mouse and keyboard util; Mark old intern/extern stuff as obsolete#650
Open
agaertner wants to merge 2 commits intoblish-hud:devfrom
Open
Add mouse and keyboard util; Mark old intern/extern stuff as obsolete#650agaertner wants to merge 2 commits intoblish-hud:devfrom
agaertner wants to merge 2 commits intoblish-hud:devfrom
Conversation
Member
|
I think no reason to do this until we switch to SDK. Only gives folks work to swap their code over which will then have to get swapped again in the future. If there are individual fixes to things here, though, you can PR those improvements to the existing implementation. |
Member
Author
|
What about not setting That reminds me, I really need some way like pins to stay up-to-date. Like a kanban. The discussions on discord just disappear too quickly. I did not follow the discussion about an SDK too much, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time I did not remove the old stuff just marked them as obsolete so existing modules won't break.
This way we can give it some time to settle until we can confidently remove the old stuff.
Also as people have pointed out the utils now take an int as keyCode instead of an enum (shorts) which is more convinient.