Skip to content

Add mouse and keyboard util; Mark old intern/extern stuff as obsolete#650

Open
agaertner wants to merge 2 commits intoblish-hud:devfrom
agaertner:refactor/mouse-keyboard-utils
Open

Add mouse and keyboard util; Mark old intern/extern stuff as obsolete#650
agaertner wants to merge 2 commits intoblish-hud:devfrom
agaertner:refactor/mouse-keyboard-utils

Conversation

@agaertner
Copy link
Member

@agaertner agaertner commented Mar 27, 2022

This time I did not remove the old stuff just marked them as obsolete so existing modules won't break.
This way we can give it some time to settle until we can confidently remove the old stuff.

Also as people have pointed out the utils now take an int as keyCode instead of an enum (shorts) which is more convinient.

@dlamkins
Copy link
Member

#502 (comment)

I think no reason to do this until we switch to SDK. Only gives folks work to swap their code over which will then have to get swapped again in the future.

If there are individual fixes to things here, though, you can PR those improvements to the existing implementation.

@agaertner
Copy link
Member Author

agaertner commented Mar 28, 2022

What about not setting error: true so they can still compile it? It gives us flexbility as SDK is still in planning (I believe)?. Or is SDK like a confirmed thing and still coming this year? I take it back if so.

That reminds me, I really need some way like pins to stay up-to-date. Like a kanban. The discussions on discord just disappear too quickly. I did not follow the discussion about an SDK too much,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants