Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal:
To add mouse button support for keybinds without introducing any breaking changes. Support middle-mouse, XButton1, and XButton2.
Implementation:
This PR adds
PrimaryMouseButtonon keybinds. Assignments to this field are mutually exclusive with thePrimaryKeyproperty. Assigning a value to one clears the other. Support for modifier keys + a mouse button has been added.Current Issues/TODO:
BlockSequenceFromGw2does not work with keybinds using mouse button bindings (it's just ignored). It will require several more changes to the MouseHandler if we want to support that. 😬MouseButtonActive()checksGameService.Input.State, but is triggered by the mouse events (which will trigger a frame before the state is updated), the keybind will sometimes fail to trigger if the button is pressed for too short of a time.