Fix incorrect calc width in WrapTextSegment

[KirillSerogodsky]

MeasureString incorrectly calculates space width.

GameService.Content.DefaultFont16.MeasureString(" ").Width = 3
there's no problem with
GameService.Content.DefaultFont16.MeasureString("_").Width = 21

Discussion Reference

No

Is this a breaking change?

No

[KirillSerogodsky]

before


after

It's not perfect, but it works better

[dlamkins]

Could you please share some more comparison screenshots of other wrapped text in Blish HUD (and perhaps in a module or two)? I want to make sure this doesn't look weird with anything existing.

[KirillSerogodsky]

I found a better solution

DefaultFont12

DefaultFont14

DefaultFont16

DefaultFont18

DefaultFont32

[KirillSerogodsky]

Module list before

Mystic Crafting before

Module info before

Pathing markers before

[KirillSerogodsky]

Module list after

Mystic Crafting after

Module info after

Pathing markers after

[KirillSerogodsky]

Legendary crafting before

after

[KirillSerogodsky]

Farming Tracker before

after

[Flyga-M]

While this seems to fix the issue well enough, I think it does make sense to implement a custom MeasureString(..) method (in the future?) that uses XAdvance instead of Width to determine glyph sizes.

MeasureString(..) is just used in so many places, that a change like that would affect many places in Core.