Conversation
| { | ||
| var services = new ServiceCollection(); | ||
|
|
||
| services |
There was a problem hiding this comment.
We will also at some point have to add all the angor services, it is a good idea to do it this way, we can also add later a method .AddAngorServices()
| namespace AngorApp.Composition; | ||
|
|
||
| public class SectionsFactory(IServiceProvider serviceProvider) : ISectionsFactory | ||
| { |
There was a problem hiding this comment.
what are sections exactly? is this like sections of the UI?
There was a problem hiding this comment.
These are the sections that appear in the Sidebar. Their have a ViewModel as content, and they are lazily loaded as needed.
| Position = NotificationPosition.BottomRight | ||
| } | ||
| )) | ||
| .AddSingleton<UIServices>(sp => new UIServices( |
There was a problem hiding this comment.
Wouldn't all those services just get resolved automatically? why this hack?
There was a problem hiding this comment.
You're absolutely right. Leftover from previous code... Will fix!
| { | ||
| var loggerFactory = LoggerConfig.CreateFactory(); | ||
| return new ProjectService( | ||
| DependencyFactory.GetIndexerService(loggerFactory), |
There was a problem hiding this comment.
normally we do not pass the logger factory to services do we?
There was a problem hiding this comment.
2 participants
Use Microsoft.Extensions.DependencyInjection to better handling of dependencies.
Includes: