Merged
Conversation
Member
|
Ah it's possible the refresh doesn't reconnect sockets |
Collaborator
Author
|
I've left the [Approve all] button unwired until we decide how it behaves. The main concern for me is how to attempt the multiple operation. Imagine there's 10 pending approvals and 1 of them fail for some reason. What should we show to the user? a summary? |
Member
I believe that's what we did in the web yes we showed a summery of all the success/failed entries |
dangershony
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, it's possible to approve investments.
Please, notice that refreshing after approval doesn't reflect the approval immediately. Please, check if something is cached.