Set of changes proposed for 1.14.0 #238
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't noticeable until I added the ability to collapse sets, but once that was added, it mattered where exactly the new set was inserted
To rename a set, you can long-press on the name of the set in the builder. In order to deal with the new variable length set names, I broke the set name and workout duration into two separate lines in the workout runner. I don't love having to eat up more vertical space that way, but don't have another amazing idea for how to deal with it and I didn't want to shrink down the font size
Makes re-organizing sets much easier and lets you focus on just the current set you're making
This is a fix for blockbasti#132 to keep the list of workouts from drawing under the nav buttons
Got removed when rebasing
Spinner granularity can be set to 5, 10, or 15 seconds in the preferences now. If a time value is entered for an exercise that cannot be shown in the spinner, then it will automatically show the text edit instead of the spinner. Changing the value to a valid spinner value will call the spinner to reappear.
This is optional functionality that you have to enable the pref to get. Once it is set, you have to tap on a spinner to get it to activate. The spinner will automatically deactivate when the user stops scrolling. When the pref is turned off, the behavior should be exactly as it is now.
Soundpool has been discontinued and no longer builds with the latest version of dart/flutter. Audioplayers seems to be the simplest drop-in replacement for the library. Upgraded all other dependencies to their latest as well and bumped up the JAWT version number.
|
Hi @blockbasti , would really love to have the app receive some updates, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.