feat(Certificate): show more info to check issuer identity

[dariomas]

Show and in order to help the user to carefully check the Issuer identity.

[codecov-io]

Codecov Report

Merging #353 into master will increase coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   71.39%   71.39%   +<.01%     
==========================================
  Files         127      127              
  Lines        1891     1895       +4     
  Branches      337      338       +1     
==========================================
+ Hits         1350     1353       +3     
- Misses        411      412       +1     
  Partials      130      130

Impacted Files	Coverage Δ
...nts/atoms/CertificateDetails/CertificateDetails.js	100% <ø> (ø)	⬆️
.../CertificateDetails/CertificateDetailsContainer.js	100% <ø> (ø)	⬆️
src/selectors/certificate.js	82.6% <75%> (-0.35%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c60517...9bbd648. Read the comment docs.

[raiseandfall]

Hi @dariomas
Thanks for the suggestion! Can you provide unit tests for that feature change?

[lemoustachiste]

Sorry I forgot to get back to you yesterday, I think it'd be nice also that URLs become links (with target="_blank"), so that people can easily make use of the information.

[dariomas]

Thank you @lemoustachiste and @raiseandfall
I will work on that soon.

[antonellopasella-kedos]

Could be useful to add the badge.issuer.image field in the header's verifier?

[antonellopasella-kedos]

URL del profilo del Issuer

[lemoustachiste]

Hm that's old, I'm not too fresh on that anymore and things have evolved with v3 cert (plus DID support).
Could you sum up again what you were trying to do? Show the URL of the issuer profile, correct?
I've had that in mind for a small while now. Since with DIDs we would still want to trust the issuer's profile origin.

[antonellopasella-kedos]

@lemoustachiste The issuer image is retrived from the issuer profile json file (external) and the bagde.issuer.image is ignored.

Can we show the badge.issuer.image in the verifier component instead of retrive from the external url?

[lemoustachiste]

The issuer image is retrived from the issuer profile json file (external) and the bagde.issuer.image is ignored.

hm this is sort of by design as the issuer's identity (or brand) can evolve through time, so as to keep things accurate.
What is your use case, to see if we could find another solution (ie component API flag or something).

Or maybe if there is no image for the distant issuer profile read the local one as a fallback, would that work for you?