feat: Pub/Sub mechanism - Pallet architecture review

.github/scripts/release/build-linux-release.sh

@@ -9,6 +9,11 @@
 
 BIN=$1
 PACKAGE=${2:-$BIN}
+# must be given as feature1,feature2,feature3...
+FEATURES=$3
+if [ -n "$FEATURES" ]; then
+  FEATURES="--features ${FEATURES}"
+fi
 
 PROFILE=${PROFILE:-production}
 ARTIFACTS=/artifacts/$BIN
@@ -17,7 +22,7 @@ echo "Artifacts will be copied into $ARTIFACTS"
 mkdir -p "$ARTIFACTS"
 
 git log --pretty=oneline -n 1
-time cargo build --profile $PROFILE --locked --verbose --bin $BIN --package $PACKAGE
+time cargo build --profile $PROFILE --locked --verbose --bin $BIN --package $PACKAGE $FEATURES
 
 echo "Artifact target: $ARTIFACTS"
 

.github/scripts/release/build-macos-release.sh

@@ -14,12 +14,17 @@ PROFILE=${PROFILE:-production}
 # write, so make it relative to github workspace.
 ARTIFACTS=$GITHUB_WORKSPACE/artifacts/$BIN
 VERSION=$(git tag -l --contains HEAD | grep -E "^v.*")
+# must be given as feature1,feature2,feature3...
+FEATURES=$3
+if [ -n "$FEATURES" ]; then
+  FEATURES="--features ${FEATURES}"
+fi
 
 echo "Artifacts will be copied into $ARTIFACTS"
 mkdir -p "$ARTIFACTS"
 
 git log --pretty=oneline -n 1
-time cargo build --profile $PROFILE --locked --verbose --bin $BIN --package $PACKAGE
+time cargo build --profile $PROFILE --locked --verbose --bin $BIN --package $PACKAGE $FEATURES
 
 echo "Artifact target: $ARTIFACTS"
 

.github/workflows/check-semver.yml

@@ -66,29 +66,29 @@ jobs:
           echo "PRDOC_EXTRA_ARGS=--max-bump minor" >> $GITHUB_ENV
 
       - name: Echo Skip
-        if: ${{ contains(github.event.pull_request.labels.*.name, 'R0-silent') }}
-        run: echo "Skipping this PR because it is labeled as R0-silent."
+        if: ${{ contains(github.event.pull_request.labels.*.name, 'R0-no-crate-publish-required') }}
+        run: echo "Skipping this PR because it is labeled as R0-no-crate-publish-required."
 
       - name: Rust Cache
-        if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-silent') }}
+        if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-no-crate-publish-required') }}
         uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6 # v2.7.8
         with:
           cache-on-failure: true
 
       - name: Rust compilation prerequisites
-        if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-silent') }}
+        if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-no-crate-publish-required') }}
         run: |
           rustup default $TOOLCHAIN
           rustup target add wasm32-unknown-unknown --toolchain $TOOLCHAIN
           rustup component add rust-src --toolchain $TOOLCHAIN
 
       - name: Install parity-publish
-        if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-silent') }}
+        if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-no-crate-publish-required') }}
         # Set the target dir to cache the build.
         run: CARGO_TARGET_DIR=./target/ cargo install [email protected] --locked -q
 
       - name: Get original PR number
-        if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-silent') }}
+        if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-no-crate-publish-required') }}
         shell: bash
         env:
           PR_TITLE: ${{ github.event.pull_request.title }}
@@ -108,7 +108,7 @@ jobs:
           echo "PR_NUMBER=$original_pr_number" >> $GITHUB_ENV
 
       - name: Check semver
-        if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-silent') }}
+        if: ${{ !contains(github.event.pull_request.labels.*.name, 'R0-no-crate-publish-required') }}
         env:
           PRDOC_EXTRA_ARGS: ${{ env.PRDOC_EXTRA_ARGS }}
           PR: ${{ env.PR_NUMBER }}

.github/workflows/release-20_build-rc.yml

@@ -47,7 +47,7 @@ jobs:
   build-polkadot-binary:
     needs: [validate-inputs]
     if: ${{ inputs.binary == 'polkadot' || inputs.binary == 'all' }}
-    uses: "./.github/workflows/release-reusable-rc-buid.yml"
+    uses: "./.github/workflows/release-reusable-rc-build.yml"
     with:
       binary: '["polkadot", "polkadot-prepare-worker", "polkadot-execute-worker"]'
       package: polkadot
@@ -69,7 +69,7 @@ jobs:
   build-polkadot-parachain-binary:
     needs: [validate-inputs]
     if: ${{ inputs.binary == 'polkadot-parachain' || inputs.binary == 'all' }}
-    uses: "./.github/workflows/release-reusable-rc-buid.yml"
+    uses: "./.github/workflows/release-reusable-rc-build.yml"
     with:
       binary: '["polkadot-parachain"]'
       package: "polkadot-parachain-bin"
@@ -91,12 +91,13 @@ jobs:
   build-polkadot-omni-node-binary:
     needs: [validate-inputs]
     if: ${{ inputs.binary == 'polkadot-omni-node' || inputs.binary == 'all' }}
-    uses: "./.github/workflows/release-reusable-rc-buid.yml"
+    uses: "./.github/workflows/release-reusable-rc-build.yml"
     with:
       binary: '["polkadot-omni-node"]'
       package: "polkadot-omni-node"
       release_tag: ${{ needs.validate-inputs.outputs.release_tag }}
       target: x86_64-unknown-linux-gnu
+      features: runtime-benchmarks
     secrets:
       PGP_KMS_KEY:  ${{ secrets.PGP_KMS_KEY }}
       PGP_KMS_HASH:  ${{ secrets.PGP_KMS_HASH }}
@@ -113,7 +114,7 @@ jobs:
   build-frame-omni-bencher-binary:
     needs: [validate-inputs]
     if: ${{ inputs.binary == 'frame-omni-bencher' || inputs.binary == 'all' }}
-    uses: "./.github/workflows/release-reusable-rc-buid.yml"
+    uses: "./.github/workflows/release-reusable-rc-build.yml"
     with:
       binary: '["frame-omni-bencher"]'
       package: "frame-omni-bencher"
@@ -135,7 +136,7 @@ jobs:
   build-chain-spec-builder-binary:
     needs: [validate-inputs]
     if: ${{ inputs.binary == 'chain-spec-builder' || inputs.binary == 'all' }}
-    uses: "./.github/workflows/release-reusable-rc-buid.yml"
+    uses: "./.github/workflows/release-reusable-rc-build.yml"
     with:
       binary: '["chain-spec-builder"]'
       package: staging-chain-spec-builder
@@ -157,7 +158,7 @@ jobs:
   build-polkadot-macos-binary:
     needs: [validate-inputs]
     if: ${{ inputs.binary == 'polkadot' || inputs.binary == 'all' }}
-    uses: "./.github/workflows/release-reusable-rc-buid.yml"
+    uses: "./.github/workflows/release-reusable-rc-build.yml"
     with:
       binary: '["polkadot", "polkadot-prepare-worker", "polkadot-execute-worker"]'
       package: polkadot
@@ -179,7 +180,7 @@ jobs:
   build-polkadot-parachain-macos-binary:
     needs: [validate-inputs]
     if: ${{ inputs.binary == 'polkadot-parachain' || inputs.binary == 'all' }}
-    uses: "./.github/workflows/release-reusable-rc-buid.yml"
+    uses: "./.github/workflows/release-reusable-rc-build.yml"
     with:
       binary: '["polkadot-parachain"]'
       package: polkadot-parachain-bin
@@ -201,12 +202,13 @@ jobs:
   build-polkadot-omni-node-macos-binary:
     needs: [validate-inputs]
     if: ${{ inputs.binary == 'polkadot-omni-node' || inputs.binary == 'all' }}
-    uses: "./.github/workflows/release-reusable-rc-buid.yml"
+    uses: "./.github/workflows/release-reusable-rc-build.yml"
     with:
       binary: '["polkadot-omni-node"]'
       package: polkadot-omni-node
       release_tag: ${{ needs.validate-inputs.outputs.release_tag }}
       target: aarch64-apple-darwin
+      features: runtime-benchmarks
     secrets:
       PGP_KMS_KEY:  ${{ secrets.PGP_KMS_KEY }}
       PGP_KMS_HASH:  ${{ secrets.PGP_KMS_HASH }}
@@ -223,7 +225,7 @@ jobs:
   build-frame-omni-bencher-macos-binary:
     needs: [validate-inputs]
     if: ${{ inputs.binary == 'frame-omni-bencher' || inputs.binary == 'all' }}
-    uses: "./.github/workflows/release-reusable-rc-buid.yml"
+    uses: "./.github/workflows/release-reusable-rc-build.yml"
     with:
       binary: '["frame-omni-bencher"]'
       package: frame-omni-bencher
@@ -245,7 +247,7 @@ jobs:
   build-chain-spec-builder-macos-binary:
     needs: [validate-inputs]
     if: ${{ inputs.binary == 'chain-spec-builder' || inputs.binary == 'all' }}
-    uses: "./.github/workflows/release-reusable-rc-buid.yml"
+    uses: "./.github/workflows/release-reusable-rc-build.yml"
     with:
       binary: '["chain-spec-builder"]'
       package: staging-chain-spec-builder

.github/workflows/release-30_publish_release_draft.yml

@@ -19,6 +19,8 @@ on:
 jobs:
   check-synchronization:
     uses: paritytech-release/sync-workflows/.github/workflows/check-synchronization.yml@main
+    secrets:
+      fork_writer_app_key: ${{ secrets.UPSTREAM_CONTENT_SYNC_APP_KEY }}
 
   validate-inputs:
     needs: [ check-synchronization ]
@@ -43,7 +45,7 @@ jobs:
     needs: [ validate-inputs ]
     uses: "./.github/workflows/release-srtool.yml"
     with:
-       excluded_runtimes: "asset-hub-rococo bridge-hub-rococo coretime-rococo people-rococo rococo rococo-parachain substrate-test bp cumulus-test kitchensink minimal-template parachain-template penpal polkadot-test seedling shell frame-try sp solochain-template polkadot-sdk-docs-first"
+       excluded_runtimes: "asset-hub-rococo bridge-hub-rococo coretime-rococo people-rococo rococo rococo-parachain substrate-test bp cumulus-test kitchensink minimal-template parachain-template penpal polkadot-test seedling shell frame-try sp solochain-template polkadot-sdk-docs-first pallet-staking-async-parachain pallet-staking-async-rc frame-storage-access-test yet-another-parachain"
        build_opts: "--features on-chain-release-build"
        profile: production
     permissions:

.github/workflows/release-31_promote-rc-to-final.yml

@@ -23,6 +23,8 @@ jobs:
 
   check-synchronization:
     uses: paritytech-release/sync-workflows/.github/workflows/check-synchronization.yml@main
+    secrets:
+      fork_writer_app_key: ${{ secrets.UPSTREAM_CONTENT_SYNC_APP_KEY }}
 
   validate-inputs:
     needs: [ check-synchronization ]

.github/workflows/release-40_publish-deb-package.yml

@@ -18,6 +18,8 @@ on:
 jobs:
   check-synchronization:
     uses: paritytech-release/sync-workflows/.github/workflows/check-synchronization.yml@main
+    secrets:
+      fork_writer_app_key: ${{ secrets.UPSTREAM_CONTENT_SYNC_APP_KEY }}
 
   validate-inputs:
     needs: [check-synchronization]

.github/workflows/release-50_publish-docker.yml

@@ -66,6 +66,8 @@ env:
 jobs:
   check-synchronization:
     uses: paritytech-release/sync-workflows/.github/workflows/check-synchronization.yml@main
+    secrets:
+      fork_writer_app_key: ${{ secrets.UPSTREAM_CONTENT_SYNC_APP_KEY }}
 
   validate-inputs:
     needs: [check-synchronization]

.github/workflows/release-99_notif-published.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         channel:
-          # Internal
+         # Internal
           - name: "RelEng: Polkadot Release Coordination"
             room: '!cqAmzdIcbOFwrdrubV:parity.io'
             pre-release: true
@@ -22,7 +22,7 @@ jobs:
             room: '!EoIhaKfGPmFOBrNSHT:web3.foundation'
             pre-release: true
 
-          # Public
+         # Public
           - name: '#polkadotvalidatorlounge:web3.foundation'
             room: '!NZrbtteFeqYKCUGQtr:matrix.parity.io'
             pre-releases: false
@@ -34,6 +34,20 @@ jobs:
             pre-releases: false
 
     steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.release.tag_name }}
+
+      - name: Extract node version
+        id: extract_version
+        run: |
+          . ./.github/scripts/common/lib.sh
+
+          version=v$(get_polkadot_node_version_from_code)
+          echo "Extracted node version: $version"
+          echo "node_version=$version" >> $GITHUB_OUTPUT
+
       - name: Matrix notification to ${{ matrix.channel.name }}
         if: github.event.release.prerelease == false || matrix.channel.pre-release
         uses: s3krit/matrix-message-action@70ad3fb812ee0e45ff8999d6af11cafad11a6ecf # v0.0.3
@@ -45,6 +59,7 @@ jobs:
             @room
 
             A new node release has been ${{github.event.action}} in **${{github.event.repository.full_name}}:**<br/>
-            Release version: [${{github.event.release.tag_name}}](${{github.event.release.html_url}})
+            Release version: [${{github.event.release.tag_name}}](${{github.event.release.html_url}})<br/>
+            Node version: ${{ steps.extract_version.outputs.node_version }}
 
             -----

.github/workflows/release-build-binary.yml

@@ -18,6 +18,10 @@ on:
         required: true
         default: "release"
         description: "The profile to use for the binary build"
+      features:
+        required: false
+        type: string
+        description: "Features to enable when building the binary (must be a list of comma-separated features)"
 
 jobs:
 
@@ -63,10 +67,10 @@ jobs:
           if [ "${{ inputs.binary }}" = "polkadot" ]; then
               for binary in polkadot polkadot-prepare-worker polkadot-execute-worker; do
                   echo "Building $binary..."
-                  ./.github/scripts/release/build-linux-release.sh $binary ${{ inputs.package }} "${PROFILE}"
+                  ./.github/scripts/release/build-linux-release.sh $binary ${{ inputs.package }} "${PROFILE}" ${{ inputs.features }}
               done
           else
-            ./.github/scripts/release/build-linux-release.sh ${{ inputs.binary }} ${{ inputs.package }} "${PROFILE}"
+            ./.github/scripts/release/build-linux-release.sh ${{ inputs.binary }} ${{ inputs.package }} "${PROFILE}" ${{ inputs.features }}
           fi
 
       - name: Upload ${{ inputs.binary }} artifacts

.github/workflows/release-reusable-rc-buid.yml → .github/workflows/release-reusable-rc-build.yml

@@ -24,6 +24,11 @@ on:
         required: true
         type: string
 
+      features:
+        description: Features to be enabled when building the binary (must be a list of comma-separated features)
+        required: false
+        type: string
+
     secrets:
       PGP_KMS_KEY:
         required: true
@@ -82,7 +87,7 @@ jobs:
       - name: Install pgpkkms
         run: |
           # Install pgpkms that is used to sign built artifacts
-          python3 -m pip install "pgpkms @ git+https://github.com/paritytech-release/pgpkms.git@e7f806f99e9be5c52f0b4a536b7d4ef9c3e695ed"
+          python3 -m pip  install "pgpkms @ git+https://github.com/paritytech-release/pgpkms.git@e7f806f99e9be5c52f0b4a536b7d4ef9c3e695ed"
           which pgpkms
 
       - name: Checkout sources
@@ -101,7 +106,7 @@ jobs:
       - name: Build binary
         run: |
           git config --global --add safe.directory "${GITHUB_WORKSPACE}" #avoid "detected dubious ownership" error
-          ./.github/scripts/release/build-linux-release.sh ${{ matrix.binaries }} ${{ inputs.package }}
+          ./.github/scripts/release/build-linux-release.sh ${{ matrix.binaries }} ${{ inputs.package }} ${{ inputs.features }}
 
       - name: Generate artifact attestation
         uses: actions/attest-build-provenance@db473fddc028af60658334401dc6fa3ffd8669fd # v2.3.0
@@ -204,7 +209,7 @@ jobs:
       - name: Install pgpkkms
         run: |
           # Install pgpkms that is used to sign built artifacts
-          python3 -m pip  install "pgpkms @ git+https://github.com/paritytech-release/pgpkms.git@e7f806f99e9be5c52f0b4a536b7d4ef9c3e695ed"
+          python3 -m pip  install "pgpkms @ git+https://github.com/paritytech-release/pgpkms.git@e7f806f99e9be5c52f0b4a536b7d4ef9c3e695ed" --break-system-packages
 
       - name: Import gpg keys
         shell: bash
@@ -216,7 +221,7 @@ jobs:
       - name: Build binary
         run: |
           git config --global --add safe.directory "${GITHUB_WORKSPACE}" #avoid "detected dubious ownership" error
-          ./.github/scripts/release/build-macos-release.sh ${{ matrix.binaries }} ${{ inputs.package }}
+          ./.github/scripts/release/build-macos-release.sh ${{ matrix.binaries }} ${{ inputs.package }} ${{ inputs.features }}
 
       - name: Generate artifact attestation
         uses: actions/attest-build-provenance@db473fddc028af60658334401dc6fa3ffd8669fd # v2.3.0

.github/workflows/release-srtool.yml

@@ -78,6 +78,7 @@ jobs:
           chain: ${{ matrix.chain }}
           runtime_dir: ${{ matrix.runtime_dir }}
           profile: ${{ inputs.profile }}
+          tag: "1.84.1"
 
       - name: Summary
         run: |