-
Notifications
You must be signed in to change notification settings - Fork 6
Tx evaluation #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tx evaluation #378
Conversation
Deploying blockfrost-platform with
|
| Latest commit: |
102ee66
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8fc9874.blockfrost-platform.pages.dev |
| Branch Preview URL: | https://feat-tx-evaluation-rebased.blockfrost-platform.pages.dev |
michalrus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I started reviewing, but then noticed that it's a draft! Left a few comments either way :)
nix/internal/unix.nix
Outdated
| in | ||
| (import inputs.flake-compat { | ||
| src = | ||
| if targetSystem != "aarch64-darwin" && targetSystem != "aarch64-linux" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a merge/rebase artifact – wrong conflict resolution? The line is repeated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 418afac
nix/internal/unix.nix
Outdated
| cp -r ${unpatched} $out | ||
| chmod -R +w $out | ||
| cd $out | ||
| patch -p1 -i ${./testgen-hs--enable-aarch64-linux.diff} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, but we already have aarch64-linux on main. Something is off here, another conflict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 418afac
crates/testgen/src/testgen.rs
Outdated
| sender: mpsc::Sender<FDRequest>, | ||
| current_child_pid: Arc<AtomicU32>, | ||
| pub struct Testgen { | ||
| pub sender: mpsc::Sender<TestgenRequest>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do these internal fields need to be public for everyone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in a53a53c
| } | ||
|
|
||
| /// This function is called at startup, so that we make sure that the worker is reasonable. | ||
| pub async fn startup_sanity_test(&self) -> Result<(), String> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But isn’t this useful? Just in case that someone plugs another binary into the libexec directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uses error serialization/deserialization. I can expect every binary integration to have a startup_sanity_test implementation of their own.
For evaluation, it's already handled via the init functionilty.
c702f03 to
a53a53c
Compare
7fb0adf to
52f662b
Compare
…ra tx-gen features)
3bcc5c5 to
e67b1a9
Compare
Implements #306
The goal of this PR is to implement tx evaluation APIs while trying to stay compatible to the Blockfrost.io version, which are:
/utils/txs/evaluate/utils/txs/evaluate/utxosWhat is added
evaluateprotocol_paramsandgenesis_configpallas_validatehandlingpallas(incomplete)What is changed
cargo.lockfile contentConsiderations
evaluatewill be built by default except windows and linux-aarch64 platforms (handled inbuild.rs).evaluateenables tx evaluation endpoints. It exists sincepallat-validatecrate isn't building for windows-all and linux-aarch64 at the moment.Please run
cargo cleanto make sure everything is in a fresh state before compiling.Haskell part: input-output-hk/testgen-hs#3