fix: preserve all headers from response metadata#51
Open
lkimtra wants to merge 1 commit intoblockscout:mainfrom
Open
fix: preserve all headers from response metadata#51lkimtra wants to merge 1 commit intoblockscout:mainfrom
lkimtra wants to merge 1 commit intoblockscout:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When forwarding headers from gRPC response metadata to HTTP response,
insert_headerwas being used which overwrites any existing headerwith the same name. This causes data loss when the metadata contains
multiple headers with the same key.
Solution
Changed from
insert_headertoappend_headerto preserve all headersfrom gRPC metadata exactly as they are, without overwriting duplicates.
Example
Headers like
Set-Cookie,Link,Warning, or any custom headers thatmay appear multiple times are now correctly forwarded to the HTTP response.