chore: Update nix-blockchain-development to 18.02.2025 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain zkVMs may use clap with versions lower than 4.5 (e.g. 4.5.9). Here we do not really care about the version, so this change will fix compatibility issues.
Allows you to add `overrideVendorCargoPackage` and `overrideVendorGitCheckout` to args, which allow the overriding of vendored dependencies, as is implemented in crane.lib. The respective attribute must be added to commonArgs (i.e. to both `buildDepsOnly` and `buildPackage` args).
Adds the ability to specify an `extraLockfile` attribute in args. Its value should evaluate to a string path. It's included in the beginning, so it overshadows dependencies, which are specified in the other Cargo.lock files. Must be added to commonArgs (i.e. to both `buildDepsOnly` and `buildPackage` args).
Syndamia
force-pushed
the
update-18-02-2025
branch
from
5202382 to
0c7499f
Compare
… toolchains Allows the host and guest program toolchains to differ. Generally, you should only need to set one.
Syndamia
force-pushed
the
update-18-02-2025
branch
3 times, most recently
from
e7217f9 to
8dd2432
Compare
This includes: - Updating flake.lock - Updating all host and guest Cargo.toml and Cargo.lock files - Making zkvm default.nix file modifications to account for toolchain and setup changes
The SDK is out of date. A PR is opened: ProjectZKM/zkm-project-template#54 However, its not certain it will be merged soon, so for now this workaround will have to do.
The newest toolchain causes errors, an issue has been filed upstream: ProjectZKM/toolchain#4 However, it is not certain when it will be resolved, so for now this workaround will be used.
Syndamia
force-pushed
the
update-18-02-2025
branch
from
8dd2432 to
aa0cd04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're using ~2 month old zkVM packages. With the merge of nix-blockchain-development's chore: Update zkVM packages 12.02.25-18.02.25, we can now update them.
This update will include certain changes to zkvmLib and zkVM setups themselves (so it is not just Cargo.lock modifications), to accomodate new toolchain and setup requirements.
Before it becomes ready to review, at least the default fibonacci guest program will be tested.