support custom analyzer

[TsXor]

#12
added a custom widget class to support custom analyzer, which looks quite primitive
(have corrected the typo in the following picture)

[rafaucau]

@luceos, could you review and merge please?

[luceos]

I'd rather see the dropdown completely removed to make it a free input type text one. This custom component, including its design (sorry), will not make things simpler for people. If you are able to take care of that, then obviously I would have no issue merging.

[TsXor]

I'd rather see the dropdown completely removed to make it a free input type text one. This custom component, including its design (sorry), will not make things simpler for people. If you are able to take care of that, then obviously I would have no issue merging.

I thought the dropdown is designed for a reason so I decide to keep it and allow custom string at the same time. As you say so, things have become quite simple.

[rafaucau]

Idea: A simpler way is to add a text field named Custom analyzer and add a help message that if the field is not empty, the custom analyzer will be used instead of the selected language.

    .registerSetting({
      setting: 'blomstra-search.custom-analyzer',
      label: app.translator.trans('blomstra-search.admin.custom-analyzer'),
      help: app.translator.trans('blomstra-search.admin.custom-analyzer-help'),
      type: 'input',
    })

And in PHP something like this:

flarum-ext-search/src/Commands/BuildCommand.php

Line 94 in f981c27

'type' => $settings->get('blomstra-search.analyzer-language') ?: 'english',

- 'type' => $settings->get('blomstra-search.analyzer-language') ?: 'english',
+ 'type' => $settings->get('blomstra-search.custom-analyzer') ?: $settings->get('blomstra-search.analyzer-language') ?: 'english',

[TsXor]

Idea: A simpler way is to add a text field named Custom analyzer and add a help message that if the field is not empty, the custom analyzer will be used instead of the selected language.

implemented in frontend:

@rafaucau @luceos

[luceos]

Although I appreciate the effort and the flexibility of listening to the ideas provided, I do think that multiple controls to manage one setting is going to cause issues.

One of the following would be my preference:

1. Using only a text field and linking to an article that shows the most common analyzers; this is necessary so that people can see their own locale/language pack reflected in a list.
2. Showing the dropdown, but adding an option "Custom" that, once selected, will make the Custom analyzer visible.

In terms of UX similarity to Flarum option 2 would be best. In terms of simplicity option 1 would be best.

The current solution however, will guarantee cause confusion and as such raise support workload, so I'm not comfortable merging it in the current state.