You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ensures the only three reserved community types available are 'senior55', 'senior62', and 'referralOnly'. If any test listings have other types added, we should remove them.
How Can This Be Tested/Reviewed?
Locally I removed the migration and reseeded. I added a listing with one of types we want to keep, one we want to remove, and one with no type I added back in the migration and changed the jurisdiction string in the file to Angelopolis, then ran the migration. Started the app again and ensured the appropriate types are associated with the correct listings. Additionally, ensured the partners listing form dropdown shows only the three expected options.
Author Checklist:
Added QA notes to the issue with applicable URLs
Reviewed in a desktop view
Reviewed in a mobile view
Reviewed considering accessibility
Added tests covering the changes
Made corresponding changes to the documentation
Ran yarn generate:client and/or created a migration when required
Review Process:
Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5470
Description
Ensures the only three reserved community types available are 'senior55', 'senior62', and 'referralOnly'. If any test listings have other types added, we should remove them.
How Can This Be Tested/Reviewed?
Locally I removed the migration and reseeded. I added a listing with one of types we want to keep, one we want to remove, and one with no type I added back in the migration and changed the jurisdiction string in the file to Angelopolis, then ran the migration. Started the app again and ensured the appropriate types are associated with the correct listings. Additionally, ensured the partners listing form dropdown shows only the three expected options.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: