feat: housing advocate user updates by matzduniuk · Pull Request #5877 · bloom-housing/bloom

matzduniuk · 2026-02-11T15:59:46Z

This PR addresses #5719

Addresses the issue in full
Addresses only certain aspects of the issue

Description

Updates the User DTOs to handle different user types: Public, Partner and Advocate
Update the user controller endpoints to handle and validate different user types

How Can This Be Tested/Reviewed?

Author Checklist:

Added QA notes to the issue with applicable URLs
Reviewed in a desktop view
Reviewed in a mobile view
Reviewed considering accessibility
Added tests covering the changes
Made corresponding changes to the documentation
Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

…w user specific DTOs

netlify · 2026-02-11T15:59:52Z

✅ Deploy Preview for bloom-angelopolis canceled.

Name	Link
🔨 Latest commit	`f71ee2e`
🔍 Latest deploy log	https://app.netlify.com/projects/bloom-angelopolis/deploys/6997b0ce0cbf220008990554

netlify · 2026-02-11T16:03:08Z

✅ Deploy Preview for partners-bloom-dev ready!

Name	Link
🔨 Latest commit	`f71ee2e`
🔍 Latest deploy log	https://app.netlify.com/projects/partners-bloom-dev/deploys/6997b0ce495b410007d2edf9
😎 Deploy Preview	https://deploy-preview-5877--partners-bloom-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-02-11T16:05:07Z

✅ Deploy Preview for bloom-exygy-dev ready!

Name	Link
🔨 Latest commit	`f71ee2e`
🔍 Latest deploy log	https://app.netlify.com/projects/bloom-exygy-dev/deploys/6997b0ce873f7900089a873a
😎 Deploy Preview	https://deploy-preview-5877--bloom-exygy-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-02-11T16:06:31Z

✅ Deploy Preview for bloom-public-seeds ready!

Name	Link
🔨 Latest commit	`f71ee2e`
🔍 Latest deploy log	https://app.netlify.com/projects/bloom-public-seeds/deploys/6997b0ced59e28000847c6aa
😎 Deploy Preview	https://deploy-preview-5877--bloom-public-seeds.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

YazeedLoonat

overall I think this looks good, left you some comments

api/src/controllers/user.controller.ts

api/src/dtos/users/user.dto.ts

api/src/services/user.service.ts

netlify · 2026-02-16T15:51:48Z

✅ Deploy Preview for partners-bloom-msq2 canceled.

Name	Link
🔨 Latest commit	`f71ee2e`
🔍 Latest deploy log	https://app.netlify.com/projects/partners-bloom-msq2/deploys/6997b0ce278e9e0009161873

…t as argument

api/src/dtos/users/partner-user-create.dto.ts

shared-helpers/src/auth/AuthContext.ts

sites/public/src/pages/account/edit.tsx

emilyjablonski

This looks stunning, fabulous, amazing!!! It's working great for me locally. I have no blocking comments, will let Yazeed take a peek.

YazeedLoonat

overall looks good, have some blocking issues for you to address

api/test/integration/permission-tests/helpers.ts

api/test/integration/permission-tests/permission-as-admin.e2e-spec.ts

api/test/integration/permission-tests/permission-as-juris-admin-correct-juris.e2e-spec.ts

api/test/integration/permission-tests/permission-as-juris-admin-wrong-juris.e2e-spec.ts

...est/integration/permission-tests/permission-as-limited-juris-admin-correct-juris.e2e-spec.ts

api/src/services/user.service.ts

…user account update call

…ndling

YazeedLoonat

looks great, tiny blocking nitpick with a path still being absolute instead of relative

api/test/unit/services/user.service.spec.ts

matzduniuk added 11 commits February 11, 2026 14:41

chore: add new Advocate User related fields to user DTO

f668a83

chore: remove generic user update and create DTOs

686424e

chore: add a new public user update and create DTOs

d689c52

chore: add a new partner user update and create DTOs

87c1b9f

chore: add a new advocate user update and create DTOs

a1297c5

chore: update user invite DTO to be partner user specific

338bf34

chore: upadte the user controller and service methods to work with ne…

5f08240

…w user specific DTOs

chore: remove unused imports

0b6993d

fix: uupdate import path to relative format

29752a8

fix: update the partner creation pipeline to use the userRoles field

3353d85

chore: add missing update DTOs as additional models to user controller

0169139

matzduniuk self-assigned this Feb 11, 2026

matzduniuk added the wip This PR is not ready for review, do not review it's a “Work In Progress” label Feb 11, 2026

YazeedLoonat reviewed Feb 11, 2026

View reviewed changes

matzduniuk added 5 commits February 12, 2026 14:39

fix: update the advocate user update dto to use AdressUpdate type

4b6350c

chore: add missing advocate user related fields to user update pipeline

7e60d6f

fix: fix imports to relative paths

1f84ab3

fix: generate new swagger types

b21c324

fix: update api layer tests to use new endpoints and DTO

1cc0967

matzduniuk added 6 commits February 16, 2026 16:55

Merge branch 'main' into 5719/housing-advocate-user-updates

da61df5

fix: remove unusued service

f0003f2

chore: update the jurisdiction field for user creation and updates

b01047d

fix: fix failing user controller integration tests

b0e13ca

chore: gupdate update sergice function to accept entire request objec…

a75e3e9

…t as argument

chore: update and re-generate swagger API types

b3382ca

emilyjablonski reviewed Feb 19, 2026

View reviewed changes

api/src/dtos/users/partner-user-create.dto.ts Show resolved Hide resolved

emilyjablonski reviewed Feb 19, 2026

View reviewed changes

shared-helpers/src/auth/AuthContext.ts Outdated Show resolved Hide resolved

emilyjablonski reviewed Feb 19, 2026

View reviewed changes

sites/public/src/pages/account/edit.tsx Show resolved Hide resolved

emilyjablonski reviewed Feb 19, 2026

View reviewed changes

YazeedLoonat requested changes Feb 19, 2026

View reviewed changes

YazeedLoonat added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels Feb 19, 2026

matzduniuk and others added 11 commits February 19, 2026 21:05

fix: remove listing redirect appURL from partner creation

4a1562f

fix: fix import paths

9afc2ec

chore: update creation address handling to use the transactions array

5850f14

fix: skip id when updating and exiting users address

d1486ef

fix: remove redundant listings and jurisdictions handling from final …

aa03f30

…user account update call

chore: move agency handling to a separated call for more graniular ha…

b5a1695

…ndling

fix: simplify jurisdictions creation for user creation pipeline

85ef057

fix: fix wrong agency id usage for diconnect

e2095a7

chore: fix failing tests

86717b2

chore: add integration tests for agency connecting and disconnecting

97186cc

Merge branch 'main' into 5719/housing-advocate-user-updates

14f3dc1

matzduniuk requested review from YazeedLoonat and emilyjablonski February 19, 2026 22:08

matzduniuk added 1 review needed Requires 1 more review before ready to merge and removed needs changes The author must make changes and then re-request review before merging labels Feb 19, 2026

YazeedLoonat approved these changes Feb 20, 2026

View reviewed changes

api/test/unit/services/user.service.spec.ts Outdated Show resolved Hide resolved

YazeedLoonat added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels Feb 20, 2026

fix: remaining relative path

f71ee2e

emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed needs changes The author must make changes and then re-request review before merging labels Feb 20, 2026

emilyjablonski merged commit 7f50f73 into main Feb 20, 2026
32 checks passed

emilyjablonski deleted the 5719/housing-advocate-user-updates branch February 20, 2026 01:16

Conversation

matzduniuk commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Can This Be Tested/Reviewed?

Author Checklist:

Review Process:

Uh oh!

netlify bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for bloom-angelopolis canceled.

Uh oh!

netlify bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for partners-bloom-dev ready!

Uh oh!

netlify bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for bloom-exygy-dev ready!

Uh oh!

netlify bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for bloom-public-seeds ready!

Uh oh!

YazeedLoonat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for partners-bloom-msq2 canceled.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emilyjablonski left a comment

Choose a reason for hiding this comment

Uh oh!

YazeedLoonat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YazeedLoonat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

matzduniuk commented Feb 11, 2026 •

edited

Loading

netlify bot commented Feb 11, 2026 •

edited

Loading

netlify bot commented Feb 11, 2026 •

edited

Loading

netlify bot commented Feb 11, 2026 •

edited

Loading

netlify bot commented Feb 11, 2026 •

edited

Loading

netlify bot commented Feb 16, 2026 •

edited

Loading