Skip to content

fix: correct fieldsets on public site#5935

Merged
emilyjablonski merged 4 commits intomainfrom
fieldsets-a11y
Feb 24, 2026
Merged

fix: correct fieldsets on public site#5935
emilyjablonski merged 4 commits intomainfrom
fieldsets-a11y

Conversation

@emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Feb 19, 2026

This PR addresses parts of related issues like #2240 #2241

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

For our public site forms:

  • Related fields should be wrapped in a fieldset (like first / middle / last name, or addresses).
  • Fieldsets need to have legends (we had some missing altogether or were using labels).

Highly recommend reviewing with the hide whitespace toggle enabled! In Voiceover, fieldsets will be read when entering the category of fields, and announced on exit.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit c26fc51
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/699875ab1ac2d300074f048e
😎 Deploy Preview https://deploy-preview-5935--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit c26fc51
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/699875ab2fe9b300088094c4
😎 Deploy Preview https://deploy-preview-5935--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit c26fc51
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/699875ab1ef1250008d64588
😎 Deploy Preview https://deploy-preview-5935--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for partners-bloom-msq2 ready!

Name Link
🔨 Latest commit c26fc51
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-msq2/deploys/699875ab278e9e0008e198d3
😎 Deploy Preview https://deploy-preview-5935--partners-bloom-msq2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit c26fc51
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/699875ab4962e3000896cf8a
😎 Deploy Preview https://deploy-preview-5935--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski marked this pull request as ready for review February 20, 2026 00:36
@emilyjablonski emilyjablonski added a11y An accessibility bug 1 review needed Requires 1 more review before ready to merge labels Feb 20, 2026
@emilyjablonski emilyjablonski changed the title fix: fieldsets fix: correct fieldsets on public site Feb 20, 2026
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YazeedLoonat YazeedLoonat added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Feb 24, 2026
@emilyjablonski emilyjablonski merged commit d98851d into main Feb 24, 2026
32 of 33 checks passed
@emilyjablonski emilyjablonski deleted the fieldsets-a11y branch February 24, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y An accessibility bug ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants