fix: error focusing in public application#5936
Merged
emilyjablonski merged 2 commits intomainfrom Feb 22, 2026
Merged
Conversation
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-msq2 canceled.
|
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
emilyjablonski
added
a11y
emilyjablonski
changed the title
ludtkemorgan
added
ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses parts of related issues like #2240 #2241
Description
In our application form, this PR deduplicates error box code, and now includes focusing on the error banner when an error is triggered so a user can re-check the form without navigating backward. Ideally we would focus on the first input with an error (which some of our other more simple forms do correctly), but our older version of react-hook-forms within this much more complex form cannot currently support this. It looks like if we upgraded it would.
How Can This Be Tested/Reviewed?
Trigger an error in the application form by not filling out a required field, hitting next, and then pressing tab to see your focus is within the alert. Previously, it would be in the footer.
Deploy preview versus core
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: