Skip to content

feat: advocate edit account#5948

Merged
emilyjablonski merged 13 commits intomainfrom
5944/advocate-create
Feb 26, 2026
Merged

feat: advocate edit account#5948
emilyjablonski merged 13 commits intomainfrom
5944/advocate-create

Conversation

@emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Feb 24, 2026

This PR addresses #5944

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This ticket assumes an advocate is already created and approved. It covers editing the account information in the user's dashboard when logged in. The work to use to same form fields to actually create the account will be a different PR.

How Can This Be Tested/Reviewed?

I separated out the sections into helper functions to reduce duplication between the public user edit account and advocate user edit account pages. We can plug any of the individual sections into account forms. We will also be able to use them for the upcoming advocate request form, and could use them on the public create form as well.

I think the per-field update button pattern we have is weird, but a redesign of this existing pattern is out of scope for these tickets.

We should test the public user edit account page and the advocate user edit account page. We should be able to update each section.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@emilyjablonski emilyjablonski added the blocked Further development is blocked waiting for something external to this ticket label Feb 24, 2026
@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for partners-bloom-msq2 canceled.

Name Link
🔨 Latest commit 3e62b72
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-msq2/deploys/69a0d046a523b600080a4b70

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit 3e62b72
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/69a0d0464c176c0008c45a01
😎 Deploy Preview https://deploy-preview-5948--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 3e62b72
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/69a0d046af76e50008ca6e17
😎 Deploy Preview https://deploy-preview-5948--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 3e62b72
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/69a0d0469fb29100082c2c04
😎 Deploy Preview https://deploy-preview-5948--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 25, 2026

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 3e62b72
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/69a0d046ac151800085a5aa9
😎 Deploy Preview https://deploy-preview-5948--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski marked this pull request as ready for review February 25, 2026 21:20
@emilyjablonski emilyjablonski added 1 review needed Requires 1 more review before ready to merge and removed blocked Further development is blocked waiting for something external to this ticket labels Feb 25, 2026
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks great!!

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Feb 26, 2026
@emilyjablonski emilyjablonski merged commit 37bfd38 into main Feb 26, 2026
32 of 33 checks passed
@emilyjablonski emilyjablonski deleted the 5944/advocate-create branch February 26, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants