You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes issues from the users / applications bash due to their malformed data including:
Allowing assets with much longer fileIds because we are having to use that for URL
Their public users have phone numbers but ours don't, so don't send phone number when updating a public user dashboard
If phone type is null don't show the broken translation
Ensure an application object exists before trying to delete it from a previous application in autofill
They have entered household member numbers inconsistently, so don't skip the live alone step in autofill as it may be inaccurate with the actual household member data
Various additional checks for empty data
Loading state on autofill page
Loading state on choose language selection
How Can This Be Tested/Reviewed?
Most of these are not easily testable in core, but will be testable in the ingestion environment. In core we can test:
Loading state on autofill page
Loading state on choose language selection
Author Checklist:
Added QA notes to the issue with applicable URLs
Reviewed in a desktop view
Reviewed in a mobile view
Reviewed considering accessibility
Added tests covering the changes
Made corresponding changes to the documentation
Ran yarn generate:client and/or created a migration when required
Review Process:
Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready to mergeShould be applied when a PR has been reviewed and approved
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emilyjablonski
added
1 review needed
mcgarrye
added
ready to merge
Description
Fixes issues from the users / applications bash due to their malformed data including:
How Can This Be Tested/Reviewed?
Most of these are not easily testable in core, but will be testable in the ingestion environment. In core we can test:
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: