Fix[mqbc]: do not alarm double assignment on AppInfos mismatch#1248
Open
678098 wants to merge 1 commit intobloomberg:mainfrom
Open
Fix[mqbc]: do not alarm double assignment on AppInfos mismatch#1248678098 wants to merge 1 commit intobloomberg:mainfrom
678098 wants to merge 1 commit intobloomberg:mainfrom
Conversation
678098
commented
Apr 2, 2026
| BSLS_ASSERT_SAFE(qs->uri() == uri); | ||
|
|
||
| if ((qs->equal(advisory))) { | ||
| if (qs->equal(advisory)) { |
Collaborator
Author
There was a problem hiding this comment.
qs->equal(advisory) == false if AppInfos are different
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098
force-pushed
the
260402_double_assignment_appInfos
branch
from
f129c5a to
634ebef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping the cache when
partitionIdandqueueKeymatch avoids the unnecessary unregister attempt while the normal registration flow still fixes any appInfo differences.