Open
Conversation
678098
changed the title
678098
force-pushed
the
260407_opt_DataStreamMessage
branch
from
2b89c87 to
965e937
Compare
hallfox
reviewed
Apr 8, 2026
Collaborator
hallfox
left a comment
hallfox
left a comment
There was a problem hiding this comment.
The is_trivially_copyable changes lgtm
dorjesinpo
reviewed
Apr 9, 2026
Collaborator
dorjesinpo
left a comment
dorjesinpo
left a comment
There was a problem hiding this comment.
The initial idea was to allocate memory on demand - potentially useful with a large number of apps.
It looks like we have a trade-off between this and slow resize.
Maybe, we can elaborate and still not allocate immediately but not use resize when there is nothing to resize?
The only use case for non empty resize is proxy when receives separate PUSH messages for the same App, same GUID.
678098
force-pushed
the
260407_opt_DataStreamMessage
branch
from
965e937 to
b2582c2
Compare
678098
changed the title
d_appsis_trivially_copyable trait
Collaborator
Author
|
Removed |
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098
force-pushed
the
260407_opt_DataStreamMessage
branch
from
b2582c2 to
9998422
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the data structs are safe to copy with
memcpy