Open
Conversation
740e3c5 to
bcd11d1
Compare
1290181 to
b2f5507
Compare
1b99541 to
e8e04fb
Compare
0346101 to
350fb8f
Compare
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
8044751 to
877ff6f
Compare
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
678098
reviewed
Apr 23, 2026
| data["myClusters"][0]["elector"]["quorum"] = quorum | ||
| f.seek(0) | ||
| json.dump(data, f, indent=4) | ||
| f.truncate() |
Collaborator
There was a problem hiding this comment.
I think this should be done by using Configurator
For example, this is how domains configuration is updated in ITs:
domains = {domain.name: domain for domain in cluster.configurator.domains}
domains[
domain_fanout
].definition.parameters.mode.fanout.publish_app_id_metrics = True
cluster.deploy_domains()
Collaborator
Author
There was a problem hiding this comment.
deploy_domains is a poor name. Will split the function into deploy_clusters and deploy_domains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_open_queue_while_cluster_blips_quorum,test_open_queue_while_cluster_blips_quorum_and_kill_all_non_leader, andtest_force_leader_primary_divergence.test_force_leader_primary_divergenceby waiting for the restarted node to be ready before killing tproxies to trigger the divergence.mqbc::ClusterUtil, removed explit load uncommitted advs to merged state.Future Work