cleanup: make ClusterCatalog ClusterInfo private#1332
Open
isodeesomlerty wants to merge 1 commit intobloomberg:mainfrom
Open
cleanup: make ClusterCatalog ClusterInfo private#1332isodeesomlerty wants to merge 1 commit intobloomberg:mainfrom
isodeesomlerty wants to merge 1 commit intobloomberg:mainfrom
Conversation
Signed-off-by: Iso Deesomlert <146564462+isodeesomlerty@users.noreply.github.com>
678098
approved these changes
Apr 24, 2026
Collaborator
678098
left a comment
678098
left a comment
There was a problem hiding this comment.
Looks good, let's wait for CI to pass (some IT failures might be unrelated)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
ClusterCatalog::ClusterInfointo the private type section now that the old AIX workaround is obsolete. This keeps the struct as an internal implementation detail while preserving existing cluster catalog behavior.Closes: #548
Verification:
cmake --build /tmp/blazingmq-issue-548/build/blazingmq --target libmqbblp.acmake --build /tmp/blazingmq-issue-548/build/blazingmq --target mqbblp.tgit clang-formatgit diff --checkNote:
ctest --test-dir /tmp/blazingmq-issue-548/build/blazingmq --output-on-failure -R '^mqbblp_'was attempted locally. Five tests passed;mqbblp_relayqueueengine.tandmqbblp_rootqueueengine.tfailed because this machine cannot resolve its local hostname (MacBook-Air-75.local) duringMessageGUIDUtil::initialize(). The failure occurs before the affectedClusterCataloglogic.