To use custom annotation it requires the type to be equality_comparable#124
Open
bruce-webb wants to merge 1 commit intobloomberg:p2996from
Open
To use custom annotation it requires the type to be equality_comparable#124bruce-webb wants to merge 1 commit intobloomberg:p2996from
bruce-webb wants to merge 1 commit intobloomberg:p2996from
Conversation
3cc9fcd to
4ffd254
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: p3394 usage
Describe your changes
When using a custom annotations and getting access to it with the function annotation_of_type the T is required to be equality_comparable.
If not the compile error message leads down to missing operator != for the type
Testing performed
When testing with new annotations types clangd reports that T doesn't meet the requires clauses. The compile message is also cleaner as well.