Allow passing args to docker user_script#5359
Merged
morgando merged 1 commit intobloomberg:mainfrom Aug 22, 2025
Merged
Conversation
Signed-off-by: mdouglas47 <mdouglas47@bloomberg.net>
roborivers
suggested changes
Aug 22, 2025
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 1/626 tests failed ⚠.
The first 10 failing tests are:
sc_downgrade
mponomar
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user_scriptis the entrypoint that kicks off our testing logic inside Docker test clusters.This change allows passing arguments to
user_script. Existing usage remains unchanged, but optional arguments let us customize behavior when needed.This prevents us from having to duplicate test scripts when we only need small variations in behavior.
Testing
Using