Fix crashes if transaction goes in wrong state#5364
Merged
akshatsikarwar merged 1 commit intobloomberg:mainfrom Aug 28, 2025
Merged
Fix crashes if transaction goes in wrong state#5364akshatsikarwar merged 1 commit intobloomberg:mainfrom
akshatsikarwar merged 1 commit intobloomberg:mainfrom
Conversation
roborivers
suggested changes
Aug 26, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 1/626 tests failed ⚠.
The first 10 failing tests are:
comdb2sys
roborivers
suggested changes
Aug 26, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 1/626 tests failed ⚠.
The first 10 failing tests are:
reco-ddlk-sql
Contributor
Author
|
subsequent queries in the handle/socket -- coming from server side |
Signed-off-by: mohitkhullar <mkhullar1@bloomberg.net>
mohitkhullar
force-pushed
the
handle_wrong_state
branch
from
e130469 to
edddc22
Compare
akshatsikarwar
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abort transaction if it goes in bad state