Interface to cancel running and queued sql statements#5375
Merged
dorinhogea merged 1 commit intobloomberg:mainfrom Sep 11, 2025
Merged
Interface to cancel running and queued sql statements#5375dorinhogea merged 1 commit intobloomberg:mainfrom
dorinhogea merged 1 commit intobloomberg:mainfrom
Conversation
roborivers
suggested changes
Sep 5, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
dorinhogea
force-pushed
the
cnoncecancell
branch
from
79245c7 to
e4ad732
Compare
roborivers
suggested changes
Sep 8, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
dorinhogea
force-pushed
the
cnoncecancell
branch
from
e4ad732 to
5e1b656
Compare
roborivers
suggested changes
Sep 8, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 1/627 tests failed ⚠.
The first 10 failing tests are:
reco-ddlk-sql
Syntax:
exec procedure sys.cmd.cancel('all') // cancel all statements in libevent sql_evbuffers
exec procedure sys.cmd.cancel('running') // cancel all running statements
exec procedure sys.cmd.cancel('queued') // cancel all queued statements
exec procedure sys.cmd.cancel('cnonce', 'uuid') // cancel 'uuid' statement, 'uuid' provided by comdb2_connections
exec procedure sys.cmd.cancel('fp', 'uuid') // cancel all fp 'uuid' statements, fp provided by comdb2_connections.
NOTE: canceled requests will show as 'queued_canceled', and so on, in comdb2_connections
Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
dorinhogea
force-pushed
the
cnoncecancell
branch
from
5e1b656 to
9409785
Compare
|
|
||
| struct rawnodestats *rawnodestats; | ||
|
|
||
| uuid_t unifieduuid; /* assigned to any statement running, used for canceling live sql */ |
Contributor
There was a problem hiding this comment.
question: is it fair to say this is what other systems might refer to as a "cancellation token"?
mponomar
approved these changes
Sep 11, 2025
Contributor
Author
|
@mponomar thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syntax:
exec procedure sys.cmd.cancel('all')
exec procedure sys.cmd.cancel('running')
exec procedure sys.cmd.cancel('queued')
exec procedure sys.cmd.cancel('cnonce', 'uuid') // from comdb2_connections
exec procedure sys.cmd.cancel('fp', 'uuid') // from comdb2_connections, client, sql dump, and so on