Physreps resync to source after truncate#5377
Merged
markhannum merged 1 commit intobloomberg:mainfrom Sep 12, 2025
Merged
Conversation
roborivers
suggested changes
Sep 8, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 3/626 tests failed ⚠.
The first 10 failing tests are:
phys_rep_tiered
cdb2sql
reco-ddlk-sql
roborivers
suggested changes
Sep 9, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
markhannum
force-pushed
the
physrep_truncate
branch
from
63baec7 to
dbc57d7
Compare
roborivers
suggested changes
Sep 10, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
mponomar
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'physrep_truncate' test, added to phys_rep_tiered, verifies that physical replicants will truncate and continue to replicate when the source has truncated its transaction log.