{182782396} Look up peer's short hostname#5739
Merged
riverszhang89 merged 1 commit intobloomberg:mainfrom Mar 8, 2026
Merged
Conversation
roborivers
suggested changes
Feb 16, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
riverszhang89
force-pushed
the
nofqdn
branch
from
49e2270 to
2b332fc
Compare
roborivers
approved these changes
Feb 23, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
silogdel [core dumped]
consumer_non_atomic_default_consumer_generated
Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
rishitha957
reviewed
Mar 6, 2026
| static int get_hostname_by_addr(struct sockaddr_in *addr, char *host, socklen_t hostlen) | ||
| { | ||
| int rc; | ||
| int flags = gbl_get_peer_fqdn ? 0 : NI_NOFQDN; |
Contributor
There was a problem hiding this comment.
curious where we defined this
rishitha957
approved these changes
Mar 6, 2026
Contributor
rishitha957
left a comment
rishitha957
left a comment
There was a problem hiding this comment.
makes sense, we use NI_NOFQDN flag to either get short or fqdn
roborivers
approved these changes
Mar 7, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated
reco-ddlk-sql
consumer_non_atomic_default_consumer_generated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch includes a slight refactoring around hostname lookup, also fixes incorrect IP address when peer drops connection.