Skip to content

{182781126} fix api_history_hung#5777

Merged
rishitha957 merged 1 commit intobloomberg:mainfrom
rishitha957:api_history_hung
Mar 6, 2026
Merged

{182781126} fix api_history_hung#5777
rishitha957 merged 1 commit intobloomberg:mainfrom
rishitha957:api_history_hung

Conversation

@rishitha957
Copy link
Contributor

fixes dangling state of curr/iter when get_next_entry is called on a hash, uses hash_for instead.
uses ctx for collecting api_history entries of node/task of clientstats.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
cldeadlock
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
load_cache_autocache_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
scindex
disttxn
sc_resume_logicalsc_generated
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
reco-ddlk-sql

mponomar
mponomar previously approved these changes Mar 3, 2026
@rishitha957 rishitha957 force-pushed the api_history_hung branch 2 times, most recently from 07a6865 to 963ccb5 Compare March 5, 2026 19:55
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
truncatesc_offline_generated [core dumped]
scindex_logicalsc_generated
sc_swapfields
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
remsql_locks_rte_connect_generated
remsql_locks
reco-ddlk-sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
sc_downgrade
truncatesc_offline_generated
reco-ddlk-sql

Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.com>
Copy link
Contributor

@riverszhang89 riverszhang89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The over-design around rwlock is also removed in this patch. This is very simple and clean now. LGTM.

@rishitha957 rishitha957 merged commit 6dfc8c8 into bloomberg:main Mar 6, 2026
4 checks passed
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
nogensc [setup failure]
scindex
scindex_logicalsc_generated
consumer_non_atomic_default_consumer_generated
unifiedcancel
reco-ddlk-sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants