Skip to content

Fix LONGREQ logs#5787

Merged
emelialei88 merged 1 commit intobloomberg:mainfrom
emelialei88:fix/longreq
Mar 20, 2026
Merged

Fix LONGREQ logs#5787
emelialei88 merged 1 commit intobloomberg:mainfrom
emelialei88:fix/longreq

Conversation

@emelialei88
Copy link
Contributor

@emelialei88 emelialei88 commented Mar 5, 2026 •
edited
Loading

This PR fixes multiple bugs / formats we have for the current LONGREQ logs:

  1. begin/commit return -1 instead of meaning for return code
  2. commit has the same fingerprint as the sql statement before it
  3. Period logs are not printed during replay
  4. Period logs missing rqid/uuid
  5. Replay count is not clear not between transactions
  6. commit log doesn't have rqid/uuid

roborivers
roborivers suggested changes Mar 6, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_downgrade [setup failure]
scindex_logicalsc_generated
disttxn
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
reco-ddlk-sql

roborivers
roborivers approved these changes Mar 6, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
reco-ddlk-sql

roborivers
roborivers suggested changes Mar 7, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated
reco-ddlk-sql
replay_eventlog
consumer_non_atomic_default_consumer_generated
eventlog

@emelialei88 emelialei88 force-pushed the fix/longreq branch 5 times, most recently from 4a27fbd to 5a8877e Compare March 12, 2026 20:10
roborivers
roborivers approved these changes Mar 13, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated
replay_eventlog
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
remsql_locks
remsql_locks_rte_connect_generated
eventlog
disttxn

@emelialei88
fix longreq logs
3d195cb 
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
roborivers
roborivers approved these changes Mar 13, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
queuedb_rollover
reco-ddlk-sql

@emelialei88 emelialei88 changed the title Fix/longreq Fix LONGREQ logs Mar 13, 2026
@emelialei88 emelialei88 marked this pull request as ready for review March 16, 2026 14:31
@emelialei88 emelialei88 merged commit 036f22c into bloomberg:main Mar 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mponomar mponomar mponomar approved these changes

+1 more reviewer

@roborivers roborivers roborivers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emelialei88 @mponomar @roborivers