Skip to content

add error number to file open error messages #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add error number to file open error messages #260

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59f09a6
add error number to file open error messages
MialLewis Oct 14, 2025
b42042f
remove unnecessary whitespace
MialLewis Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pystack/_pystack/elf_common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ getSectionInfo(const std::string& filename, const std::string& section_name, Sec
LOG(DEBUG) << "Trying to locate .PyRuntime data offset from program headers";
file_unique_ptr file(fopen(filename.c_str(), "r"), fclose);
if (!file || fileno(file.get()) == -1) {
LOG(ERROR) << "Cannot open ELF file " << filename;
LOG(ERROR) << "Cannot open ELF file " << filename << " (" << std::strerror(errno) << ")";
return false;
}
const int fd = fileno(file.get());
Expand Down Expand Up @@ -559,7 +559,7 @@ getBuildId(const std::string& filename)
LOG(DEBUG) << "Trying to locate .PyRuntime data offset from program headers";
file_unique_ptr file(fopen(filename.c_str(), "r"), fclose);
if (!file || fileno(file.get()) == -1) {
LOG(ERROR) << "Cannot open ELF file " << filename;
LOG(ERROR) << "Cannot open ELF file " << filename << " (" << std::strerror(errno) << ")";
return "";
}
const int fd = fileno(file.get());
Expand Down