John C — Sprint-Challenge-Mongo

[frankfaustino]

No description provided.

[frankfaustino]

👌

[frankfaustino]

Missing some semi-colons ; in this file.

[frankfaustino]

We should be using camelCase for variable names.

[frankfaustino]

HTTP status code should be 201, since we're creating a new document and sending it to our client (Postman).

https://httpstatuses.com/201

[frankfaustino]

Not to be too pedantic 😆, but for readability's sake, we should be adding spaces inside curly braces, after commas and colons:

const ExpenseSchema = new Schema({
    amount: {
        type: Number,
        required: true
    },
    description: {
        type: String,
        required: true
    },
    budget: {
        type: Schema.Types.ObjectId,
        ref: 'Budget'
    },
    category: {
        type: Schema.Types.ObjectId,
        ref: 'Category'
    }
}

https://github.com/airbnb/javascript#whitespace--comma-spacing
https://github.com/airbnb/javascript#whitespace--in-braces

[frankfaustino]

Instead of sending the budget and category ObjectId along with the POST request, we can send a POST request that looks like this:

{
	"amount": 35,
	"description": "potatoes",
	"budget": "Monthly Spending",
	"category": "Groceries"
}

In order to do that, we need to add some logic to our route:

.post((req, res) => {
  let { amount, budget, category, description } = req.body

  budget = Budget.findOne({ title: budget })
  category = Category.findOne({ title: category })

  Promise.all([budget, category])
    .then(([budget_id, category_id]) => {
      const expense = new Expense({
        amount,
        budget: budget_id,
        category: category_id,
        description
      })

      expense.save()
        .then(response => res.status(201).json(response))
        .catch(err => res.status(500).json(err.message))
    })
    .catch(err => res.status(500).json(err.message))
  })

We have to get budget and category with the findOne method, then using Promise.all, we grab the ObjectId for each from the response from MongoDB, then create our new Expense.

[frankfaustino]

Well done! You are doing a great job, John! 😊 Please review the individual comments I left then close this PR once done.