Jesse Reichel — Sprint-Challenge-Mongo

[frankfaustino]

No description provided.

[frankfaustino]

👌

[frankfaustino]

Since we're not using the variables title and budgetAmount for anything, we could just pass req.body to our new Budget: const budget = new Budget(req.body) and skip the whole object destructuring thing.

[frankfaustino]

Character spacing here is a bit off. According to Airbnb's styleguide (https://github.com/airbnb/javascript#whitespace--in-braces), there should be spaces inside curly braces.

Also, we don't need to use object destructuring here.

[frankfaustino]

Since Expenses are many-to-one relationship with Budgets, this budget property shouldn't be an array.

[frankfaustino]

Same here, there are many Expenses per Category, but only one Category for each, so this property shouldn't be in an array.

[frankfaustino]

Instead of sending the budget and category ObjectId along with the POST request, we can send a POST request that looks like this:

{
	"amount": 35,
	"description": "potatoes",
	"budget": "Monthly Spending",
	"category": "Groceries"
}

In order to do that, we need to add some logic to our route:

.post((req, res) => {
  let { amount, budget, category, description } = req.body

  budget = Budget.findOne({ title: budget })
  category = Category.findOne({ title: category })

  Promise.all([budget, category])
    .then(([budget_id, category_id]) => {
      const expense = new Expense({
        amount,
        budget: budget_id,
        category: category_id,
        description
      })

      expense.save()
        .then(response => res.status(201).json(response))
        .catch(err => res.status(500).json(err)))
    })
    .catch(err => res.status(500).json(err))
  })

We have to get budget and category with the findOne method, then using Promise.all, we grab the ObjectId for each from the response from MongoDB, then create our new Expense.

[frankfaustino]

Well done, Jesse! You've clearly got a good grasp of the material from last week.

I know it wasn't clear in the assignment's instructions that you have to fetch the budget and category ObjectIds before saving them to an Expense. But consider how the client (Postman, React app, or whatever) would even know what those ObjectIds are to begin with.

Otherwise, good job! Keep up the excellent work 😊