Skip to content

Bee Choeung#266

Open
Beeness wants to merge 2 commits intobloominstituteoftechnology:masterfrom
Beeness:master
Open

Bee Choeung#266
Beeness wants to merge 2 commits intobloominstituteoftechnology:masterfrom
Beeness:master

Conversation

@Beeness
Copy link

@Beeness Beeness commented Jun 15, 2018

No description provided.

@designerexpert
Copy link

Comments

  • Good Job Achieving MVP
  • I see the reviews are helping solidify the understanding on the topics, It shows in the answers you gave.
  • I think the only thing missing now is those stretch goals.

@@ -0,0 +1,9 @@
const mongoose = require('mongoose');
const ObjectId = mongoose.Schema.Types.ObjectId;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you are going to need this line on this specific file, since nothing is being linked in here.

@@ -0,0 +1,8 @@
const mongoose = require('mongoose');
const ObjectId = mongoose.Schema.Types.ObjectId;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise in Category ObjectId is not needed.

amount: { type: Number, required: true },
description: { type: String, required: true },
//link to budget
budget: [{ type: ObjectId, ref: 'Budget'}], // Monthly Spending

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid way of linking the schema to another one, for populating later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants