Skip to content

Conversation

@blooop
Copy link
Owner

@blooop blooop commented Dec 30, 2025

Summary by Sourcery

Integrate the ty type-checking tool into the project’s development workflow.

Build:

  • Add ty as a test/development dependency in pyproject configuration.

CI:

  • Extend lint and CI task pipelines to run ty checks alongside existing linting steps.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 30, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds the ty type-checking tool as a development dependency and integrates it into the project’s lint and CI workflows.

Flow diagram for the updated lint command including ty

flowchart LR
  Dev[Developer] -->|runs| LintCmd[lint task]

  subgraph LintPipeline
    direction LR
    RuffLint[ruff-lint]
    Pylint[pylint]
    TyCheck[ty check]
  end

  LintCmd --> RuffLint
  RuffLint --> Pylint
  Pylint --> TyCheck
  TyCheck --> Result[lint result]
Loading

File-Level Changes

Change Details Files
Introduce ty as a dev dependency and wire it into lint and CI task chains.
  • Add ty to the test dependency group in pyproject.toml
  • Define a new ty task that runs ty check in the tool configuration
  • Update the lint task to depend on the ty task in addition to existing linters
  • Update the ci task so that ty runs as part of the continuous integration pipeline
pyproject.toml
Update editor and environment lock configuration to reflect the new tooling.
  • Adjust VS Code recommended extensions configuration (details in diff)
  • Regenerate or update pixi.lock to capture the new dependency state
.vscode/extensions.json
pixi.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider loosening the ty<=0.1.0 constraint (e.g. ty>=0.1.0,<0.2.0) so that minor non-breaking releases can be picked up without needing to bump the lock file immediately.
  • Since ty is used as a linting-style check, you may want to place it in a dedicated [project.optional-dependencies] group (e.g. dev or lint) rather than test to better reflect its purpose.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider loosening the `ty<=0.1.0` constraint (e.g. `ty>=0.1.0,<0.2.0`) so that minor non-breaking releases can be picked up without needing to bump the lock file immediately.
- Since `ty` is used as a linting-style check, you may want to place it in a dedicated `[project.optional-dependencies]` group (e.g. `dev` or `lint`) rather than `test` to better reflect its purpose.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@blooop blooop merged commit 2646125 into main Dec 30, 2025
7 checks passed
@blooop blooop deleted the feature/ty branch December 30, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants