-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/ty #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/ty #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds the Flow diagram for the updated lint command including tyflowchart LR
Dev[Developer] -->|runs| LintCmd[lint task]
subgraph LintPipeline
direction LR
RuffLint[ruff-lint]
Pylint[pylint]
TyCheck[ty check]
end
LintCmd --> RuffLint
RuffLint --> Pylint
Pylint --> TyCheck
TyCheck --> Result[lint result]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Consider loosening the
ty<=0.1.0constraint (e.g.ty>=0.1.0,<0.2.0) so that minor non-breaking releases can be picked up without needing to bump the lock file immediately. - Since
tyis used as a linting-style check, you may want to place it in a dedicated[project.optional-dependencies]group (e.g.devorlint) rather thantestto better reflect its purpose.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider loosening the `ty<=0.1.0` constraint (e.g. `ty>=0.1.0,<0.2.0`) so that minor non-breaking releases can be picked up without needing to bump the lock file immediately.
- Since `ty` is used as a linting-style check, you may want to place it in a dedicated `[project.optional-dependencies]` group (e.g. `dev` or `lint`) rather than `test` to better reflect its purpose.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Integrate the
tytype-checking tool into the project’s development workflow.Build:
tyas a test/development dependency in pyproject configuration.CI:
tychecks alongside existing linting steps.