use dependson for node

[blooop]

Summary by Sourcery

Enhancements:

• Clarify installation script messaging to reflect that Node.js is provided via devcontainer dependsOn configuration.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Switches devcontainer Node.js installation wiring from the deprecated installsAfter mechanism to dependsOn, and updates messaging accordingly, plus associated devcontainer and ignore configuration tweaks.

Flow diagram for Claude Code install script Node.js check using dependsOn

flowchart TD
    Start([install_claude_code])
    CheckNode{node and npm in PATH?}
    ErrorMsg[Display error about Node.js feature dependsOn]
    Install[Install Claude Code CLI globally]
    End([Done])

    Start --> CheckNode
    CheckNode -- No --> ErrorMsg
    ErrorMsg --> End
    CheckNode -- Yes --> Install
    Install --> End

Loading

File-Level Changes

Change	Details	Files
Update Claude Code devcontainer installation script messaging to align with Node.js being provided via dependsOn.	Adjust comment describing how Node.js and npm are installed in the devcontainer Update error message text to reference Node.js feature being declared via dependsOn instead of installsAfter	.devcontainer/claude-code/install.sh
Align devcontainer feature and workspace configuration with the new dependsOn-based Node.js setup.	Update Claude Code devcontainer feature metadata to use or reflect dependsOn for Node.js instead of installsAfter Adjust root devcontainer configuration to work with the updated feature dependencies Tweak .gitignore entries to match the updated devcontainer/feature layout or generated artifacts	.devcontainer/claude-code/devcontainer-feature.json .devcontainer/devcontainer.json .gitignore

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.devcontainer/claude-code/install.sh:13-20` </location>
<code_context>

-    # Verify Node.js and npm are available
+    # Verify Node.js and npm are available (should be installed via dependsOn)
     if ! command -v node >/dev/null || ! command -v npm >/dev/null; then
         cat <<EOF

 ERROR: Node.js and npm are required but not found!

-This should not happen as the Node.js feature is automatically installed
-via the 'installsAfter' mechanism in devcontainer-feature.json.
+This should not happen as the Node.js feature is declared in 'dependsOn'.

 Please check:
 1. The devcontainer feature specification is correct
</code_context>

<issue_to_address>
**issue (bug_risk):** The error path prints a message but does not explicitly exit with a non-zero status.

In this branch, the script logs an error but then continues running. Since `set -e` only reacts to failing commands and the heredoc itself succeeds, the script may proceed with an invalid environment when Node.js/npm are missing. Add an explicit `exit 1` after the heredoc to ensure the script stops in this case.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}