Open
Conversation
GuyL99
requested changes
Feb 13, 2023
|
No newline at end of file |
||
| lazy_static = "1.4.0" | ||
|
|
||
| [dev-dependencies] |
Contributor
There was a problem hiding this comment.
There is nothing in them...
Cargo.toml
Outdated
| tokio = { version = "^1.23", features = ["rt-multi-thread", "macros"]} | ||
| clap = { version = "4.0.29", features = ["derive"] } | ||
| const_format = "0.2.30" | ||
| cherrybomb-engine = {path = "cherrybomb-engine"} |
Collaborator
Author
There was a problem hiding this comment.
Yes not need to comment on that.
Dev-dependencies does not relevant, so I 've no choice to modify it every time
src/table.rs
Outdated
| options: &Options, | ||
| use_colors: bool, | ||
| ) -> anyhow::Result<ExitCode> { | ||
| let color_choice = if !use_colors { |
Contributor
There was a problem hiding this comment.
This whole thing with the ColorChoice seems rather redundant, you should have just used the static vars directly without an enum
Collaborator
Author
There was a problem hiding this comment.
Yes , I understand so I removed the enum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I just added support for colors.
Tell me if the "colored" struct need to be improve or maybe remove some fields.
Looking for any feedback :)