Add set_output method in FeatureAugmenter #1111
Open
DrozdovMK wants to merge 2 commits intoblue-yonder:mainfrom
Open
Add set_output method in FeatureAugmenter #1111DrozdovMK wants to merge 2 commits intoblue-yonder:mainfrom
DrozdovMK wants to merge 2 commits intoblue-yonder:mainfrom
Conversation
… sklearn pipelines
Collaborator
|
Thanks @DrozdovMK for the contribution (and sorry for the delay in the review). I am fine with your code changes. Can you add a very small trivial unit test for your use case so that we can ensure, it will not be problematic again in the future? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An error occurs when using
sklearn.pipeline.FeatureUnionwithFeatureAugmenterintransformer_list. When calling theset_output(transform="pandas")method on the FeatureUnion object, it triggers iterative method calls for all objects specified intransformer_list.The custom transformer must implement the
set_outputmethod to be compatible with scikit-learn's API. Otherwise we get an error:if not hasattr(estimator, "set_output"):
--> 458 raise ValueError(
459 f"Unable to configure output for {estimator} because
set_output"460 "is not available."
461 )