-
Notifications
You must be signed in to change notification settings - Fork 87
Replace boost with C++20 #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bd133a9 to
a91a0a0
Compare
bgemmill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, I had a few nits around nanosecond handling and epoch encocing, and it looks like all of this may just require cpp17 rather than 20.
Thanks for looping me in from the issue!
|
@bgemmill thanks for the help. I did my best to address the comments. |
|
Thanks! This looks really promising. Could you try and do some kind of performance test? The last time I removed some boost code the performance got worse and we needed to introduce |
I have no experience with migrations like this. The tests pass, but it definitely needs a second pair of eyes.