Add support for host parameter (Shopify App Bridge >= 2.0)#33
Open
andrewleek-droplab wants to merge 2 commits intobluebeel:mainfrom
Open
Add support for host parameter (Shopify App Bridge >= 2.0)#33andrewleek-droplab wants to merge 2 commits intobluebeel:mainfrom
andrewleek-droplab wants to merge 2 commits intobluebeel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt at adding support for the host parameter and as such Shopify App Bridge >= 2.0. This seems to be working fine for me, but if I have missed some integration, please let me know and I can make the necessary changes.
I added an error response to handle 'host' being undefined, so this might break if using a Shopify App Bridge version below 2.0, but I have not tested this. My feeling is that this is a moot point since we should be using the latest Shopify App Bridge.
This issue was raised here:
#23
Thanks for all your work on this library!