support separate mailboxes#6
Open
tjaartvdwalt wants to merge 2 commits intobluerail:masterfrom
tjaartvdwalt:master
Open
support separate mailboxes#6tjaartvdwalt wants to merge 2 commits intobluerail:masterfrom tjaartvdwalt:master
tjaartvdwalt wants to merge 2 commits intobluerail:masterfrom
tjaartvdwalt:master
Conversation
This feature allows multiple POP accounts, to connect to `post_office`. Each account will receive only the mail sent the the address that corresponds to the POP client `username`.
Member
|
Thanks, @tjaartvdwalt. I didn't even notice this PR. I'll give it a review ASAP and merge it in |
|
@rvanlieshout any updates? |
Member
|
Should mailbox have a NUM parameter? |
Member
|
@tjaartvdwalt, i've tested it locally and it works. The thing I don't get is the need for NUM? Shouldn't we remove that as an argument? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a
--mailboxswitch, that allowspost_officeto use separate mailboxes.With this feature enabled, a POP client receives only messages that are sent to the email address that corresponds to the POP username.