Do not disable joystick forwarding automatically when multiple joysticks connect at the same time #2351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…oysticks connect at the same time
rafaellehmkuhl
force-pushed
the
fix-joystick-multiple-controllers-connecting-together
branch
from
f7cbaf9 to
5ab7026
Compare
Member
Author
|
@ArturoManzoli I believe you have a Windows machine, right? If so, could you test this PR there? It should be tested by connecting two different joysticks to the computer and then opening Cockpit. It works if the joystick forwarding does not get disabled in the end of the startup. To be tested on Web as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple joysticks connect together, the first one enables message forwarding (if no other GCS is detected) but the second joystick will always disable the forwarding, as it will detect the messages from the first one and the
thereWereJoysticksBeforevariable was already computed as false. Now it does account for that case correctly.The artifacts for this fix cherry-picked to 1.17.0 can be found here.
Fix #2346