rainbow: improve proxy errors, and use atclient#1359
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rainbowdaemon (implemented in thesplitterpackage) proxies some XRPC requests through to a backing relay instances (as well as doing best-effort forwarding to other "sibling" relay instances).This PR is intended to change how errors from that proxying are reported. If the upstream relay returns an XRPC error (eg, with JSON body and the expected fields), it will pass back the same XRPC error (same status code, name, and message). If there is some other error, it will now return an HTTP Bad Gateway (502) error, instead of 500, and will only include a generic error message. It will now log the full error.
NOTE: this needs manual testing before merge and deploy