Merged
Conversation
arcalinea
temporarily deployed
to
samuel/patch-fractional-font-size-issue - social-app PR #9199
Render
Destroyed
|
estrattonbailey
approved these changes
Oct 15, 2025
NekoDrone
added a commit
to NekoDrone/catsky-social
that referenced
this pull request
Oct 16, 2025
* Nightly source-language update * feat(link-meta): Tweaks `getLinkMeta` to whitelist trusted hostnames (bluesky-social#9139) * patch delete audio compression for 16kb compat (bluesky-social#9149) * feat: hide embeds for moderated posts (bluesky-social#9152) * check for self labels when determining if we should hide embeds * nit * [16KB] use 16kb-compatible fork of react-native-mmkv (bluesky-social#9150) * use 16kb-compatible fork of react-native-mmkv * avoid using package alias * specify ndk version * Revert "specify ndk version" This reverts commit 5773935. * add compiler flags to mmkv build (bump version) * move fork to bsky repo/npm org * fix: show both DisplayName and Handle in google structured data (or only Handle if DisplayName not set) * fix: copy-paste mistake and more idiomatic structured data format * Auto-select search results tab (bluesky-social#9159) When the user clicks the search button next to "Discover New Feeds" or "Suggested Accounts" on the Explore page, we'll auto-select the respective search results tab (feeds or users). * Fix language prompt text wrap issue (bluesky-social#9175) * reply button in feeds opens thread (bluesky-social#9143) * the reply button should open the replies to a post, not present a text input for you to enter your Big Thought into. i think a lot of people don’t even realize that the point has already been written * Feature gate, fix event --------- Co-authored-by: Eric Bailey <git@esb.lol> * Nightly source-language update * Add validation to threadgate records, check for max hidden replies (bluesky-social#9178) * Ship activation experiments (bluesky-social#9170) * ship onboarding experiments * delete logged out cta * delete other loggedoutcta * add 10% sample rate to sentry (bluesky-social#9182) * Tweak greens (bluesky-social#9177) * tweak greens * undo test code * Placeholder style tweaks (bluesky-social#9107) * Align colors in loading placeholders * Same for new skele components * Increase opacity of disabled replies button slightly * fix background colors (bluesky-social#9174) * move aspect ratio to atom (bluesky-social#9171) * fix hider alignment in thread (bluesky-social#9168) * Fix chat request buttons not moving with swipe gesture (bluesky-social#9155) * portal in buttons so they move with swipe * remove outline style buttons * Add accessibilityRole to single images (bluesky-social#9148) * Keep the screen awake on the video feed (bluesky-social#9146) * fix android admonition flex collapse issue (bluesky-social#9120) * fix newline backspace behaviour (bluesky-social#9038) * fix border color of feed/list embeds (bluesky-social#9021) * Fix profile label section soft reset scroll (bluesky-social#9103) * Fix profile label section scrollto * revert back to headerHeight * move feed context on desktop (bluesky-social#9015) * Fix add/edit moderation list form placeholder text (bluesky-social#9074) * fix placeholder text of modlist dialog * change header font weight * fix string * Value prop screen - polish, convert to pager (bluesky-social#9133) * turn value prop screen into a pager on native * rm ts-ingore * fix pager swipe on android --------- Co-authored-by: Eric Bailey <git@esb.lol> * Bump alf package to include new colors (bluesky-social#9187) * Change anchor text size to `lg` from `xl` (bluesky-social#9185) * Combine SubtleWebHover and SubtleHover, default to web only for all cases (bluesky-social#9188) * prompt user to log in on hashtag screen * Nightly source-language update * tidy up post reasons (bluesky-social#9194) * fix label spacing (bluesky-social#9195) * enable numberOfLines on replyTo component (bluesky-social#9196) * Remove remaining usages of old post thread query (bluesky-social#9184) * Remove remaining usages of old post thread query * Add PostThreadContext, cache mutator for threadgates on threads, pipe it through * Replace getPostThread in threadgate query * Replace in initQuote handling, which isn't even used rn... * Missing import * Revert ext change * Nightly source-language update * Fix ternary in moderation settings that caused a double title (bluesky-social#9198) * Remove log (bluesky-social#9204) * use hasSession * Nightly source-language update * Add metrics for when OPs click "hide reply for me" or "hide reply for everyone" (bluesky-social#9206) * [Onboarding] Add starterpacks step (bluesky-social#9007) * add onboarding starterpacks step * tweak starter pack cards * fix web styling * use new API * add screen transitions to onboarding * skip host account * bump limit to 6 * tweak font weight * rm commented out code * fix yarn.lock * limit starter packs experiment to english speakers * cache pages in explore feed previews (bluesky-social#9082) * make sure border radius matches inset border (bluesky-social#9207) * delay toast after posting (bluesky-social#9208) * change flatlist config for explore page (bluesky-social#9083) * fix invalid tweaking to date string (bluesky-social#8415) * add large content viewer to tabs (bluesky-social#8394) * Haptic on profile buttons (bluesky-social#6034) * play haptic on profile buttons * change react import * Fix computation of `isLastSibling`, `isLastChild`, and `replyIndex` (bluesky-social#9202) * Fix computation of isLastSibling and isLastChild to account for muted or otherwise hidden replies * Update comments * isLastSiblingByCounts isn't needed, should rely only on the count of replies seen * The counters serve the same purpose, we only need to know the count of the actual replies rendered to the view in order to calculate the replyIndex * Remove redundant check * patch fractional font size issue (bluesky-social#9199) * add sort import suggestions plugin (bluesky-social#8335) * Move interests clientside and add `finance` (bluesky-social#9176) * move interests clientside * add finance * try and ensure there's always data for the "all" category * add empty state for suggested accounts * simplify error wording * Remove notice in create account flow (bluesky-social#9209) * Remove notice of policy updates * Rm debug code * Nightly source-language update * update xcode (bluesky-social#9215) * [Release prep] 1.109.0 E2E fixes (bluesky-social#9216) * list tests * fix create account * get onboarding e2e tests working * get curate list test working * Update thread-muting.yml * update app icon (bluesky-social#9219) * [Release prep] 1.109.0 translations (bluesky-social#9218) * intl:pull * intl:extract:all * fix: theming (again) (again) (again) ad infinitum --------- Co-authored-by: pfrazee <1270099+pfrazee@users.noreply.github.com> Co-authored-by: Eduardo Rosendo <eduardojra96@gmail.com> Co-authored-by: Samuel Newman <mozzius@protonmail.com> Co-authored-by: Elijah Seed-Arita <elijaharita@gmail.com> Co-authored-by: Hailey <me@haileyok.com> Co-authored-by: jim <310223+jimmylee@users.noreply.github.com> Co-authored-by: Alex Benzer <abenzer@users.noreply.github.com> Co-authored-by: easrng <easrng@gmail.com> Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: Chenyu Huang <itschenyu@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch of bluesky-social/react-native-uitextview#39
uitextview pr description below:
Certain fractional font sizes cause the calculation where we estimate the number of lines to be off, causing a phantom extra line.
This code path is really only needed for when the
numberOfLinesprop is set along with a custom line height. This PR just skips this codepath where possible - thus the bug remains whennumberOfLinesis set, but fixes the common case.