Draft Table model and general refactoring#106
Draft
tacaswell wants to merge 9 commits intobluesky:masterfrom
Draft
Draft Table model and general refactoring#106tacaswell wants to merge 9 commits intobluesky:masterfrom
tacaswell wants to merge 9 commits intobluesky:masterfrom
Conversation
Member
|
The ipywidgets ecosystem finally has a performant table widget, just in time for us. https://github.com/bloomberg/ipydatagrid/blob/main/examples/DataGrid.ipynb |
We will want to be able to put tables into layouts the same way, but Axes does not make sense in that case.
Warn if the shim module is imported.
tacaswell
force-pushed
the
enh_LiveTable
branch
from
cea4eb4 to
163c742
Compare
Contributor
Author
|
Rebased. |
danielballan
changed the title
| if figure is plot_builder.figure: | ||
| self.plot_builders.remove(plot_builder) | ||
| elif hasattr(plot_builder, "figures"): | ||
| # This code looks broken, was untested, and TAC is not |
Member
There was a problem hiding this comment.
I can't figure out what looks broken about this. I think it works and is being used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still work done in prep of implementing an auto LiveTable.
Unlike plotting where all-of-dataset access is helpful, tables are well -suited to streaming ("print the latest news"), so this is likely going to depend on bluesky/bluesky-live#15 going in so we can mostly re-use the logic from LiveTable.