Open
Conversation
Contributor
Author
|
Relies on bluesky/bluesky-live#19 |
mrakitin
reviewed
Sep 13, 2021
Member
mrakitin
left a comment
mrakitin
left a comment
There was a problem hiding this comment.
I don't have much to add, but I can't provide a very informed review as I don't know the codebase very well. Maybe worth having a meeting to go over the architecture and the structure of the code and the goals.
By the way, are the CI failures expected?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the
debouncedecorator frombluesky-liveto space out the callbacks coming from thenew_dataevent so that we don't lock up the application when new data is coming in faster than the app can handle. The kafka and zmq dispatchers have been updated to process new data when it comes in and theLOADING_LATENCYvalues have been increased.Motivation and Context
These changes are to help ease the line painter issue where the app receiving live data would lock up because it couldn't handle the new data fast enough.
How Has This Been Tested?
Tested interactively with replayed "live" data from the IOS beamline