Make validation optional for all data sources #875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielballan
approved these changes
Nov 4, 2025
Member
danielballan
left a comment
danielballan
left a comment
There was a problem hiding this comment.
This is much cleaner than injecting a _validate parameter into sres_parameters. 👍
Member
|
Moved to bluesky/bluesky-tiled-plugins#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing to Tiled, a consolidator has an option to validate the data structure before putting the
data_source(typically, this is faster than post-factum updates). However, this validation requires access to the files on the client-side. To avoid running into permission errors when the client may not have reading permissions on the server filesystem, this PR makes validation optional globally (as a parameter passed to TiledWriter) instead of relying on in-band parameters.