Allow greater IDs for Aet Sets #37
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch breaks the limit of IDs for Aet Sets in
aet_dbby reworking the way those entries are looked up.By default, what the game does is:
aet_dbfiles;This lookup array makes the game crash when using big IDs for Aet Sets as the game tries to allocate too much memory. Instead, what this patch does is remove this lookup array and search for the entry directly in the sorted vector created previous to it.
Advantages:
Disadvantages:
O(1)toO(log N), as it uses binary search, but realistically the difference should be almost null)